Skip to content
GitLab
项目 群组 主题 代码片段
  • /
  • 帮助
    • 帮助
    • 支持
    • 社区论坛
    • 提交反馈
  • 登录
  • L large
  • 项目信息
    • 项目信息
    • 动态
    • 标记
    • 成员
  • 仓库
    • 仓库
    • 文件
    • 提交
    • 分支
    • 标签
    • 贡献者统计
    • 分支图
    • 比较修订版本
  • 议题 21
    • 议题 21
    • 列表
    • 看板
    • 服务台
    • 里程碑
  • 合并请求 12
    • 合并请求 12
  • CI/CD
    • CI/CD
    • 流水线
    • 作业
    • 产物
    • 计划
  • 部署
    • 部署
    • 环境
    • 发布
  • 软件包与镜像库
    • 软件包与镜像库
    • 软件包库
    • 容器镜像库
    • Terraform 模块
    • 模型实验
  • 监控
    • 监控
    • 事件
  • 分析
    • 分析
    • 价值流
    • CI/CD
    • 仓库
  • Wiki
    • Wiki
  • 代码片段
    • 代码片段
  • 动态
  • 分支图
  • 创建新议题
  • 作业
  • 提交
  • 议题看板
收起侧边栏
  • 王权利
  • large
  • 议题
  • #6328

Return username parameter in UserSafe entity

Created by: jefferai

The internal API contains a "/discover" method to allow gitlab-shell to find out the name associated with a key_id. This is filtered via UserSafe to contain only the "name" parameter.

Right now, the only use of both /discover and UserSafe is to allow this functionality in case audit_usernames = true. However, fetching the username from a key_id is a very useful thing to have as keying behavior off of usernames is often far easier than keying behavior off of numeric IDs.

My proposal is to modify UserSafe to expose ":name, :username" instead of just ":name". I don't think this is unsafe (you're not returning the email, after all) and doesn't incur meaningful additional overhead, but vastly helps those of us that need to add logic in the hook before/after the gitlab-shell update call.

I've tried this small change locally and it works well.

指派人
分配到
工时统计